Import 'cpuset' from kubernetes repository in kubernetes/utils #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8d2832021ad049eee6f184315a10f3abe18036f9.
- Move from the old github.com/golang/glog to k8s.io/klog - klog as explicit InitFlags() so we add them as necessary - we update the other repositories that we vendor that made a similar change from glog to klog * github.com/kubernetes/repo-infra * k8s.io/gengo/ * k8s.io/kube-openapi/ * github.com/google/cadvisor - Entirely remove all references to glog - Fix some tests by explicit InitFlags in their init() methods Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
Signed-off-by: Ted Yu <yute@vmware.com>
Obtain unsorted slice in cpuAccumulator#freeCores
Add test for CPUSet#UnionAll
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
- ToSliceInt64 returns sorted slice of cores IDs in int64 format - ToSliceNoSortInt64 returns slice of cores IDs in int64 format Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Add e2e tests for the new GetAllocatableResources API. The tests are added in the `podresources_test` suite created previously in this series. Signed-off-by: Francesco Romani <fromani@redhat.com>
Migrate remaining pkg/kubelet/cm/ top level files to structured logging
The cpuset.Parse function missed a couple bad input cases, specifically "1--3" and "10-6". These were silently ignored when they should instead be flagged as invalid. This now catches these cases and expands the unit tests for cpuset to cover them (and other negative test cases as well). Signed-off-by: Jim Ramsay <jramsay@redhat.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: chymy <chang.min1@zte.com.cn>
iancoolidge
requested review from
cici37 and
SergeyKanzhelev
and removed request for
SergeyKanzhelev and
cici37
|
This code was pulled out of the CPUManager in the /lgtm |
k8s-ci-robot
added
the
lgtm
iancoolidge
force-pushed
the
devel-cpuset
branch
from
6985ced
to
de7f266
Compare
k8s-ci-robot
removed
the
lgtm
Done |
SergeyKanzhelev
approved these changes
Mar 3, 2023
k8s-ci-robot
added
the
lgtm
* Note that this came from kubernetes repository * Remove emeritus owners * Add klueska, dchen1107, ffromani, klueska, SergeyKanzhelev to owners
iancoolidge
force-pushed
the
devel-cpuset
branch
from
de7f266
to
3aa0d1f
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iancoolidge, klueska, SergeyKanzhelev, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rayowang
pushed a commit
to rayowang/kubernetes
that referenced
this pull request
Feb 9, 2024
Feedback from kubernetes/utils#267 and related reviews. * Equality when insertion order is different * UnsortedList contents * Not-Subset cases * Clone coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
Fixes #266
See also kubernetes/kubernetes#112899 for background and source repository details
Release note: